Review request for 7131196 - [macosx] Cmd-Q does not quit a graphical Java app

[Anton V. Tarasov]

On 25.01.2012 17:02, Anthony Petrov wrote:
> Hi Anton,
>
> On 1/25/2012 5:58 PM, Anton V. Tarasov wrote:
>> Please review a fix for 7131196.
>>
>> webrev: http://cr.openjdk.java.net/~ant/7131196/webrev.0/
>>
>> -[NSView performKeyEquivalent:] serves to listen to key events with
>> modifiers. Currently it returns NO (FALSE). This prevents NSApp from
>
> You meant TRUE (YES) here, right? :)

Ah, right! Thanks for the correction =)

Anton.

>
>> processing the event by default. For instance, CMD+Q doesn't close
>> the app.
>>
>> The fix is to return NO from the method. So, it will allow default
>> processing for all the events with modifiers (along with dispatching
>> them to Java).
>
> The fix looks good to me.
>
> -- 
> best regards,
> Anthony