Review request for 7124316: [macosx] Passive and Peered IMF Client does not cope with input methods
Artem Ananiev
artem.ananiev at oracle.com
Wed Jan 25 07:12:21 PST 2012
On 1/24/2012 7:28 PM, Alexander Zuev wrote:
> Artem,
>
> i did, but this method itself will need to be updated then and all it
> actually does is
> doing a bunch of irrelevant checks and then creates a new event so i
> will have to add a
> machinery that will do it for InputMethodEvent and then finally just
> uses AWTAccessor.
> It's really an overkill - we might do it much simpler just by forwarding
> existing event to
> the right component.
OK, I got it. The only thing that bothers me is that Swing text
delegates may not process input method events targeted to other
components correctly, but as long as you've proved them to work, I'm
fine with the fix.
Thanks,
Artem
> Thanks,
> Alex
>
> On 1/24/12 13:04, Artem Ananiev wrote:
>> Hi, Alex,
>>
>> did you consider using LWComponentPeer's sendEventToDelegate() method
>> instead of AWTAccessor?
>>
>> Thanks,
>>
>> Artem
>>
>> On 1/23/2012 11:06 PM, Alexander Zuev wrote:
>>> Hello,
>>>
>>> please review the following fix:
>>> http://cr.openjdk.java.net/~kizune/7124316/webrev.01/
>>>
>>> the bug description is here:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124316
>>> The previous fix, while needed, solved problem only for a small set of
>>> locales.
>>> This fix should solve it for all the locales for heavyweight text
>>> components.
>>>
>>> Thanks,
>>> Alex
>
More information about the macosx-port-dev
mailing list