Review request for 7124393: [macosx] JCheckBox in JTable: checkbox doesn't alaways respond to the first mouse click

[Alexander Potochkin]

Hello Anthony

> Thanks for the confirmation, Alex. I'm OK with the fix then.

Thanks!

alexp
>
> -- 
> best regards,
> Anthony
>
> On 1/27/2012 5:08 PM, Alexander Potochkin wrote:
>> Hello Anthony
>>>
>>> 6711682 describes an issue related to actions produced by user only:
>>>
>>>> A DESCRIPTION OF THE PROBLEM :
>>>> The cell editor is a JCheckBox and the table stays in edit mode 
>>>> after clicking the JCheckBox.
>>>> If you are in editing mode and click on an other row of the same 
>>>> column to select/unselect the JCheckBox, only each second time the 
>>>> value changed.
>>
>> it is about mouse clicking, not about pressing any keys.
>> It is me, as the author of the test case for 6711682, decided to 
>> explicitly stop editing but for the *last cell only*
>>>
>>> If we follow this procedure manually on the Mac with the original 
>>> test case for 6711682, will we reproduce the problem described in 
>>> that CR? If the answer to this is yes, then we have to find a way to 
>>> fix 6711682 for the Mac as well, and this (I suppose) should provide 
>>> us with a way to emulate the stopEditing() action by means of using 
>>> Robot.
>>>
>>> Could you please verify this?
>>
>> The original test for 6711682 (which is provided in the description) 
>> is not reproducible on Mac or any platform because it is fixed,
>> and the fix in the code, shared by all LaFs
>>
>> verified
>>
>>>
>>> Also, a question to Mike: can we update Aqua L&F to add a binding 
>>> for the start/stopEditing() action?
>>
>> If Aqua LaF guidelines doesn't require this action we shouldn't add 
>> it without a reasonable request from the customers
>>
>> Thanks
>> alexp
>>
>>>
>>> -- 
>>> best regards,
>>> Anthony
>>>
>>>
>>>>
>>>> Thanks
>>>> alexp
>>>>
>>>>>
>>>>> -- 
>>>>> best regards,
>>>>> Anthony
>>>>>
>>>>> On 1/23/2012 9:33 PM, Alexander Potochkin wrote:
>>>>>> Hello
>>>>>>
>>>>>> Please review the following fix:
>>>>>> http://cr.openjdk.java.net/~alexp/7124393/webrev.00/
>>>>>>
>>>>>> the bug's description is here:
>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124393
>>>>>>
>>>>>> The bug is in the test, F2 doesn't stop editing on MacOS,
>>>>>> we should not use the keyboard to commit the data
>>>>>>
>>>>>> the test is also updated
>>>>>> to access the Swing methods on the Event Dispatching Thread only
>>>>>>
>>>>>> Thanks
>>>>>> alexp
>>>>
>>