Review request for 7131793: [macosx] some cleanup in OGL pipeline code

Mike Swingler swingler at apple.com
Fri Jan 27 08:39:14 PST 2012


On Jan 27, 2012, at 7:17 AM, Dmitry Cherepanov wrote:

> Hello,
> 
> Here's some changes to remove some stale code from the OGL pipeline. This code has been introduced as a part of the initial implementation for CALayer-based rendering and disabled by the changes for MACOSX_PORT-766.
> 
> http://cr.openjdk.java.net/~dcherepanov/7131793/webrev.1/

One tiny detail: I'd recommend using -jObjectWithEnv: instead of -jObject here (because it's a little faster to not re-fetch the env):
+    JNFCallVoidMethod(env, [self.javaLayer jObject], jm_drawInCGLContext);

I'm very glad to see this code getting shorter, and using a retain/release wrapper around the JNI global refs.

Looks great,
Mike Swingler
Apple Inc.



More information about the macosx-port-dev mailing list