RFR 7132637: (dc) DatagramChannel multicast tests failing on MacOSX
Alan Bateman
Alan.Bateman at oracle.com
Sun Jan 29 13:42:20 PST 2012
On 29/01/2012 20:33, Michael McMahon wrote:
> Can I get the following webrev reviewed please?
>
> http://cr.openjdk.java.net/~michaelm/7132637/webrev.1/
Just as background to this. The javadoc is clear that support for
source-specific multicast (both include mode and exclude mode) is
optional. The changes in this webrev just mean that the block or 3-arg
join methods will throw UOE. The return JNI_FALSE in
canIPv6SocketJoinIPv4Group0 just means that DatagramChannels to IPv6
sockets can't join IPv4 groups, again something the javadoc is clear is
not guaranteed to be supported.
Michael - the changes are fine and identical to a patch that I have in
my repo too. All I suggest is adding a comment to each ifdef so that
readers know what is about. Also I would suggest intending in
blockOrUnblock6 to make it easier to read.
-Alan
More information about the macosx-port-dev
mailing list