Review request for 7132809: [macosx] MAXIMIZED_BOTH set before setVisible(true) hides Frame

Artem Ananiev artem.ananiev at oracle.com
Mon Jan 30 02:51:52 PST 2012


Hi, Anthony,

the fix looks fine.

A minor comment: can we use peer.getState() instead of (instanceof check 
+ target.getExtendedState()) in CPlatformWindow.setVisible()?

Thanks,

Artem

On 1/26/2012 7:41 PM, Anthony Petrov wrote:
> Hello,
>
> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7132809 at:
>
> http://cr.openjdk.java.net/~anthony/x-11-MaximizedBoth-7132809.0/
>
> We shouldn't apply the extended state when a window is hidden. With this
> fix the CPlatformWindow.setVisible() re-applies the state when the
> window gets shown.
>
> --
> best regards,
> Anthony


More information about the macosx-port-dev mailing list