Review request for 7129732 - [macosx] JCK failure: no focus transfer back to Window owner

Anton V. Tarasov anton.tarasov at oracle.com
Mon Jan 30 04:05:13 PST 2012


A question to the reviewers. Do we still need to invoke on EDT?

  236         // it is important to call this method on EDT
  237         // to prevent the deadlocks during the painting of the lightweight delegates
  238         //TODO: WHY? This is a native-system related call. Perhaps NOT calling
  239         // the painting procedure right from the setVisible(), but rather relying
  240         // on the native Expose event (or, scheduling the repainting asynchronously)
  241         // is better?
  242         SwingUtilities.invokeLater(new Runnable() {
  243             @Override
  244             public void run() {
  245                 platformWindow.setVisible(visible);

Thanks,
Anton.

On 30.01.2012 15:42, Anton V. Tarasov wrote:
> Hello,
>
> Please review a fix for 7129732.
>
> webrev: http://cr.openjdk.java.net/~ant/7129732/webrev.0/
>
> When a focused simple window is getting closed, focus should be
> transferred to the owner.
>
> Thanks,
> Anton.
>
>



More information about the macosx-port-dev mailing list