Review request for 7131793: [macosx] some cleanup in OGL pipeline code
Dmitry Cherepanov
dmitry.cherepanov at oracle.com
Mon Jan 30 05:59:11 PST 2012
Mike Swingler wrote:
> On Jan 27, 2012, at 7:17 AM, Dmitry Cherepanov wrote:
>
>> Hello,
>>
>> Here's some changes to remove some stale code from the OGL pipeline.
>> This code has been introduced as a part of the initial implementation
>> for CALayer-based rendering and disabled by the changes for
>> MACOSX_PORT-766.
>>
>> http://cr.openjdk.java.net/~dcherepanov/7131793/webrev.1/
>> <http://cr.openjdk.java.net/%7Edcherepanov/7131793/webrev.1/>
>
> One tiny detail: I'd recommend using -jObjectWithEnv: instead of
> -jObject here (because it's a little faster to not re-fetch the env):
> + JNFCallVoidMethod(env, [self.javaLayer jObject], jm_drawInCGLContext);
On second thought, seems like -jObject simply returns the global
reference that the wrapper holds without obtaining the env. What's the
reason for re-fetching the env?
Thanks,
Dmitry
More information about the macosx-port-dev
mailing list