Review request for 7129732 - [macosx] JCK failure: no focus transfer back to Window owner
Anthony Petrov
anthony.petrov at oracle.com
Tue Jan 31 03:38:20 PST 2012
On 1/31/2012 5:12 PM, Anton V. Tarasov wrote:
>>>> Please review a fix for 7129732.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~ant/7129732/webrev.0/
>>
>> At line 255 a check for !visible is unnecessary since the else branch
>> already ensures that visible is false.
>
> Indeed. I added the first if-statement and forget to refine the second
> one. Thanks for catching this.
>
> Please, see the improved version:
>
> http://cr.openjdk.java.net/~ant/7129732/webrev.1
Looks fine.
--
best regards,
Anthony
>
> Thanks,
> Anton.
>
>>
>> Otherwise looks good.
>>
>> --
>> best regards,
>> Anthony
>>
>>
>>>>
>>>> When a focused simple window is getting closed, focus should be
>>>> transferred to the owner.
>>>>
>>>> Thanks,
>>>> Anton.
>>>>
>>>>
>>>
>
More information about the macosx-port-dev
mailing list