[7u6] Please review my fix for 7177144: [macosx] Drag and drop not working (regression in 7u6)

Oleg Pekhovskiy oleg.pekhovskiy at oracle.com
Thu Jul 19 06:04:02 PDT 2012


Looks fine.

Oleg.

7/19/2012 5:05 PM, Alexander Zuev wrote:
> Artem,
>
>   you are right. Kind of. We have to check in both places so you can 
> find my updated webrev at
> http://cr.openjdk.java.net/~kizune/7177144/webrev.01
>
> With best regards,
> Alex
>
> On 7/19/12 16:18, Artem Ananiev wrote:
>> Hi, Alex,
>>
>> you put the check to EventQueue.cacheEQItem(), which doesn't look 
>> right. coalesceEvent() is the correct place, isn't it?
>>
>> Thanks,
>>
>> Artem
>>
>> On 7/17/2012 8:27 PM, Alexander Zuev wrote:
>>> Hello,
>>>
>>> please review my fix 7177144: [macosx] Drag and drop not working
>>> (regression in 7u6)
>>> CR description can be found here:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7177144
>>>
>>> Webrev with the proposed change can be seen here:
>>> http://cr.openjdk.java.net/~kizune/7177144/webrev.00
>>>
>>> This fix affects all platforms but due to the fix nature it shouldn't
>>> cause any regressions. The idea of the fix is to prevent Drag and Drop
>>> events from coalescing because it may cause hangup due to the
>>> synchronous nature of this type of events.
>>>
>>> With best regards,
>>> Alex
>
>



More information about the macosx-port-dev mailing list