[8] Please review my fix for 7124247: [macosx] Implement GraphicsDevice.setDisplayMode()

[Artem Ananiev]

Hi, Alex,

here are some comments:

1. Please, update copyright dates in file headers.

2. I would pass w, h, bpp and refrate as method params to 
setDisplayMode() to avoid extra JNI calls from native

3. Is it possible to call setDisplayMode() with a DisplayMode object 
that was not obtained via previous getDisplayModes() call? If the answer 
is "no", why don't you just check for exact match for all parameters (w, 
h, bpp, refrate) in getBestModeForParameters()?

Thanks,

Artem

On 6/1/2012 1:40 PM, Alexander Zuev wrote:
> Hello,
>
> please review my fix for CR 7124247: [macosx] Implement
> GraphicsDevice.setDisplayMode()
>
> CR description can be found here:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124247
>
> Webrev with the proposed change can be seen here:
> http://cr.openjdk.java.net/~kizune/7124247/jdk8/webrev.00
>
> With best regards,
> Alex