<AWT Dev> [7u6] Review request for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category

[Leonid Romanov]

Ok, I've played with the app bundler project. It looks like we don't have to do anything to ensure that CFBundleName has higher priority than JAVA_MAIN_CLASS_<pid>.  You see, we don't set the app name directly: instead, we use whatever string we have for the app name to set JRSAppNameKey property, the rest happens in the Apple code. My experiments show that Apple handles JRSAppNameKey the same way my fix handles the Dock icon: if it has already been specified via Info.plist, then don't set it.  

On 06.06.2012, at 19:55, Igor Nekrestyanov wrote:

> IMHO, for testing grab sample from
>   javaweb.us.oracle.com/~inekrest/native-bundles
> 
> Install it and then tweak Info.plist as needed.
> 
> -igor
> 
> On 6/6/12 8:33 AM, Scott Kovatch wrote:
>> Your best bet is to start with the app bundler project on java.net.
>> 
>> http://java.net/projects/appbundler
>> 
>> It's an ant script that will take a JAR file and turn it into a bundled app.
>> 
>> Also, the latest builds of javafxpackager will now generate a bundled app, too.
>> 
>> -- Scott
>> 
>> On Jun 1, 2012, at 8:27 AM, Leonid Romanov wrote:
>> 
>>> Hi Scott,
>>> Could you please provide me with instructions how to create my own bundled app? There is a couple of things I want to test...
>>> 
>>> On 31.05.2012, at 20:20, Scott Kovatch wrote:
>>> 
>>>> I think what Artem is saying is that if the application is bundled, and CFBundleName is set, it should take higher priority than JAVA_MAIN_CLASS_<pid>.
>>>> 
>>>> If that is what you are saying, Artem, I agree. :-)
>>>> 
>>>> We're straying away from the original review, though.
>>>> 
>>>> -- Scott
>>>> 
>>>> On May 31, 2012, at 8:30 AM, Artem Ananiev<artem.ananiev at oracle.com>  wrote:
>>>> 
>>>>> Hi, Leonid,
>>>>> 
>>>>> shouldn't app name set in the bundler be of higher priority than JAVA_MAIN_CLASS_<pid>  value, set by Java launcher?
>>>>> 
>>>>> Thanks,
>>>>> 
>>>>> Artem
>>>>> 
>>>>> On 5/29/2012 8:59 PM, Leonid Romanov wrote:
>>>>>> Well, the order is the following: first, we check if -Xdock:name has been set. If it hasn't, we check for the "apple.awt.application.name" property. If this property hasn't been set, we try to get the app name from the JAVA_MAIN_CLASS_<pid>   environment variable, which is used to pass  the name of a Java class whose main() method was invoked by the Java launcher code to start the application. If JAVA_MAIN_CLASS_<pid>   hasn't been set, then as the last resort we try to get the app name from the bundle.
>>>>>> 
>>>>>> On 28.05.2012, at 19:35, Artem Ananiev wrote:
>>>>>> 
>>>>>>> On 5/28/2012 6:06 PM, Leonid Romanov wrote:
>>>>>>>> Hi,
>>>>>>>> The problem with the application name is that the app in question uses "com.apple.mrj.application.apple.menu.about.name" property to set its name. Mu understanding is that we don't support this property in OpenJDK.
>>>>>>> OK, fine. Is the application name set correctly when it is passed from app bundle or as -Xdock:name?
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> 
>>>>>>> Artem
>>>>>>> 
>>>>>>>> On 28.05.2012, at 16:46, Artem Ananiev wrote:
>>>>>>>> 
>>>>>>>>> Hi, Leonid,
>>>>>>>>> 
>>>>>>>>> the fix looks fine. Is the application name issue (also mentioned in 7159381) addressed in another fix?
>>>>>>>>> 
>>>>>>>>> Thanks,
>>>>>>>>> 
>>>>>>>>> Artem
>>>>>>>>> 
>>>>>>>>> On 5/24/2012 5:23 PM, Leonid Romanov wrote:
>>>>>>>>>> Hi,
>>>>>>>>>> Please review a fix for 7159381: [macosx] Dock Icon defaults to Generic Java Application Category. The problem here is that we ignore the fact that for the bundled app its icon might be specified via Info.plist file. In this case OS X sets the icon for us, so we don't have to do anything.
>>>>>>>>>> 
>>>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7159381
>>>>>>>>>> Webrev:  http://cr.openjdk.java.net/~leonidr/7159381/webrev.00/
>>>>>>>>>> 
>>>>>>>>>> Thanks,
>>>>>>>>>> Leonid.
>>>>>>>>>> 
>