[8] Review request for 7170716: JVM crash when opening an AWT app from a registered file. [WAS: Re: Patch for #7170716, crash in OSXAPP_SetApplicationDelegate]

Marco Dinacci marco.dinacci at gmail.com
Thu Jun 21 07:11:13 PDT 2012


Hi,

> This looks good. I'd also suggest making it an atomic property, and also converting the queue to be a property as well. Using -> notation to directly pick at Obj-C ivars across threads is generally considered bad form.

I agree making the queue a property, I think using "->" for ivars is
an Oracle convention but I changed the code to use the dot syntax
since I converted the queue to a property.

Thanks for the comments, attached new patch.

Best,
Marco


More information about the macosx-port-dev mailing list