[8] Review request for 7170716: JVM crash when opening an AWT app from a registered file. [WAS: Re: Patch for #7170716, crash in OSXAPP_SetApplicationDelegate]

[Anthony Petrov]

Hi Marco,

The fix is now in the repository:

http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e7dc778d768e

Thank you very much for the contribution.

--
best regards,
Anthony

On 6/21/2012 6:24 PM, Anthony Petrov wrote:
> Hi Marco and Mike,
> 
> I've uploaded the latest patch as a webrev to:
> 
> http://cr.openjdk.java.net/~anthony/8-34-crashInSetApplicationDelegate-7170716.3/ 
> 
> 
> The fix still looks fine to me. I'll push it to JDK 8 tomorrow unless 
> there are any objections.
> 
> -- 
> best regards,
> Anthony
> 
> On 06/21/12 18:11, Marco Dinacci wrote:
>> Hi,
>>
>>> This looks good. I'd also suggest making it an atomic property, and 
>>> also converting the queue to be a property as well. Using ->  
>>> notation to directly pick at Obj-C ivars across threads is generally 
>>> considered bad form.
>>
>> I agree making the queue a property, I think using "->" for ivars is
>> an Oracle convention but I changed the code to use the dot syntax
>> since I converted the queue to a property.
>>
>> Thanks for the comments, attached new patch.
>>
>> Best,
>> Marco