[7u6] Review request for 7179349: [macosx] Java processes on Mac should not use default Apple icon

Leonid Romanov leonid.romanov at oracle.com
Sun Jun 24 11:33:37 PDT 2012


Hi, 
Please review a fix for 7179349: [macosx] Java processes on Mac should not use default Apple icon.
Currently, OpenJDK uses Apple supplied icon found in /System/Library/Frameworks/JavaVM.framework as the default icon for Java apps. This fix makes it use an icon that comes with OpenJDK instead. 
We do it by converting the icon file to an .h file which contains the icon data as an array of bytes  and then including the .h file where the icon data is needed. So, we basically compile in the icon data into the binaries. Such approach was chosen because this is what we do on other platforms (Linux, Windows) and because it is the easiest way to access the icon data during runtime.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7179349
Webrev:  http://cr.openjdk.java.net/~leonidr/7179349/webrev.00/

Note: this is a freshly filled bug, so my understanding is it may take a while until it becomes visible via bug's link above.

Thanks,
Leonid.
 



More information about the macosx-port-dev mailing list