[8] Review request for 7174718: [macosx] Regression in 7u6 b12: PopupFactory leaks DefaultFrames.

Artem Ananiev artem.ananiev at oracle.com
Mon Jun 25 05:38:57 PDT 2012


Looks fine.

Thanks,

Artem

On 6/22/2012 7:55 PM, Anthony Petrov wrote:
> Hello,
>
> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7174718 at:
>
> http://cr.openjdk.java.net/~anthony/8-37-AWTWindowLeak-7174718.0/
>
> This fix does the following:
>
> 1. Restores the correct CFRetainedResource's logic for CPlatformWindow.
>
> 2. Releases an instance of AWTWindow when disposing the peer to release
> a reference to the NSWindow object held in the nsWindow property of
> AWTWndow.
>
> 3. After creating an NSWindow object, it is released because the
> nsWindow property retains it already.
>
> The PopupFactory test passes after these changes.
>
> --
> best regards,
> Anthony


More information about the macosx-port-dev mailing list