[7u4] Review request for 7148281: [macosx] JTabbedPane tabs with HTML text do not render correctly

Alexander Zuev alexander.zuev at oracle.com
Fri Mar 2 05:54:10 PST 2012


Ok then. Fix looks fine to me.

On 3/2/12 14:14, Alexander Scherbatiy wrote:
> On 3/2/2012 3:23 AM, Alexander Zuev wrote:
>> Alexander,
>>
>>    In the comments above the condition you've changed noted that this 
>> code is for non-scrolling tabs only. Could you please check that when 
>> tab scrolling is set to on there's no problem with HTML labels and 
>> custom component painter?
>     The WRAP_TAB_LAYOUT policy is not applicable on Aqua L&F so only 
> SCROLL_TAB_LAYOUT is used.
>
>     I tried the sample where a custom component is set with the plain 
> and html titles. This works in both cases when all tabs are shown on 
> the frame and when a frame size is small so right and left scroll 
> arrows are shown.
>
>    Thanks,
>    Alexandr.
>
>> With best regards,
>> Alexander Zuev
>>
>> 27.02.2012, в 17:12, Alexander 
>> Scherbatiy<alexandr.scherbatiy at oracle.com>  написал(а):
>>
>>> Hello,
>>>
>>>   Please review the fix for bug 7148281: [macosx] JTabbedPane tabs 
>>> with HTML text do not render correctly
>>>
>>>   Bug description is 
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7148281
>>>
>>>   Webrev can be found at: 
>>> http://cr.openjdk.java.net/~alexsch/7148281/webrev.00/
>>>
>>>   In case if a component is set for a tab title there is no need to 
>>> paint the tab title one more time.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>



More information about the macosx-port-dev mailing list