[7u4] Request for review: 7124548 [macosx] Memory leak in JOptionPane.createDialog

[Scott Kovatch]

The change itself looks fine. Do you need to guard against someone using the object after dispose() is called or will the NPEs just indicate a programmer error of some kind?

-- Scott

On Mar 6, 2012, at 4:40 AM, Sergey Bylokhov wrote:

> Does anybody has a chance to review it?
> Thanks.
> 
> 29.02.2012 16:49, Sergey Bylokhov wrote:
>> Hi Everyone,
>> It would be good to break connection to window peer when we dispose CGLayer. Because CGlayer can be used in the CGLSurfaceData which can be cached in BufferedContext.validatedSrcData.
>> 
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124548
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/7124548/webrev.00/
>> 
> 
> 
> -- 
> Best regards, Sergey.
>