Request for review 7151821: [macosx] Mnemonic doesn't work in JTabbedPane
Leonid Romanov
leonid.romanov at oracle.com
Tue Mar 13 08:24:41 PDT 2012
Hi,
What is the test case for this issue? What Control+alt+char is supposed to do?
On 13.03.2012, at 17:13, Alexander Scherbatiy wrote:
> Please review a fix for 7151821.
>
> webrev: http://cr.openjdk.java.net/~alexsch/7151821/webrev.00/
>
>
> This is a fix for regression after switching using [event charactersIgnoringModifiers] string to [event characters] during the MACOSX_PORT-568 issue fixing:
> http://java.net/jira/browse/MACOSX_PORT-568
> http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/rev/5780795f381e
>
> The characters string is null during Ctrl+Alt+Char mnemonic pressing.
>
> According to the NSEvent charactersIgnoringModifiers doc:
> This method returns the non-modifier key character pressed for dead keys, such as Option-e.
> For example, Option-e (no shift key) returns an “e" for this method, whereas the characters method returns an empty string.
>
> The fix uses the charactersIgnoringModifiers string for the keychar when the Ctrl+Alt mnemonic key combination is pressed.
>
> Thanks,
> Alexandr.
>
More information about the macosx-port-dev
mailing list