[7u4] Review request for 7154072 [macosx] swallowing key events

Anthony Petrov anthony.petrov at oracle.com
Tue Mar 20 06:59:21 PDT 2012


Hi Anton,

The fix looks fine to me.

--
best regards,
Anthony

On 3/20/2012 5:53 PM, Anton V. Tarasov wrote:
> Hello,
> 
> Please review a fix for 7154072.
> 
> webrev: http://cr.openjdk.java.net/~ant/7154072/webrev.1
> 
> A pointer to NSEvent was used to compare current and previous key events 
> in order to skip repetitive ones. The pointer didn't retain the object 
> and when a new key event object was allocated by the same address the 
> events were considered equal. The latter was erroneously skipped.
> 
> A new regression test is provided as well.
> 
> Thanks,
> Anton.
> 
> 


More information about the macosx-port-dev mailing list