Request for review 7156194: [macosx] Can't type non-ASCII characters into applets

[Anthony Petrov]

Thanks for the clarification. The fix looks fine to me then.

--
best regards,
Anthony

On 03/26/12 18:56, Dmitry Cherepanov wrote:
> Anthony Petrov wrote:
>> Hi Dmitry,
>>
>> Do we ever pass 'false' as the needsKeyTyped argument? I see only one
>> call to the handleKeyEvent() method at CPlatformView, and it always
>> passes true.
>>
>> Where is the CEmbeddedFrame.handleKeyEvent() called from?
>
> Hi Anthony,
>
> It's called from the Plugin code and it's 'false' for Firefox. In this
> case, the Plugin gets TextInput event even if it's US layout and we
> would get double KEY_TYPED events without suppressing one of these events.
>
> Thanks,
> Dmitry
>
>>
>> --
>> best regards,
>> Anthony
>>
>> On 03/26/12 17:54, Dmitry Cherepanov wrote:
>>> Hello,
>>>
>>> Here's a fix for 7156194 ([macosx] Can't type non-ASCII characters into
>>> applets])
>>>
>>> The fix implements CEmbeddedFrame.handleInputEvent
>>> (NPCocoaEventTextInput handler) and sends KEY_TYPED event for each
>>> character of the incoming string. Also, it introduces new
>>> "needsKeyTyped" parameter to CEmbeddedFrame.handleKeyEvent method to
>>> prevent getting double KEY_TYPED events.
>>>
>>> http://cr.openjdk.java.net/~dcherepanov/7156194/webrev.0/
>>>
>>> Thanks,
>>> Dmitry
>>>
>