Request for review 7156191 [macosx] Can't type into applet demos in Pivot

Dmitry Cherepanov dmitry.cherepanov at oracle.com
Mon Mar 26 08:55:21 PDT 2012


Hi Artem,

Artem Ananiev wrote:
>
> The fix looks fine. CEmbeddedFrame.updateOverlayWindowActiveState() 
> JavaDoc may be corrected, though: does it still post a 
> WINDOW_ACTIVATED event?

I think that the comment is still valid. The code generates a 
WINDOW_ACTIVATED event when the embedded frame becomes the active window.

Thanks,
Dmitry

>
> Thanks,
>
> Artem
>
> On 3/26/2012 6:37 PM, Dmitry Cherepanov wrote:
>> Hello,
>>
>> Here's a fix for 7156191 ([macosx] Can't type into applet demos in 
>> Pivot)
>>
>> The current implementation of focus event handlers in CEmbeddedFrame
>> dispatches focus events directly to the embedded frame. The fix changes
>> the implementation and now it calls peer.notifyActivation() like it's
>> done in standalone mode.
>>
>> http://cr.openjdk.java.net/~dcherepanov/7156191/webrev.0/
>>
>> Thanks,
>> Dmitry
>>



More information about the macosx-port-dev mailing list