[7u4] request for review: 7154047: [macosx]When we choose print one page in the print dialog,it still prints all the pages.

[Anthony Petrov]

Looks great.

--
best regards,
Anthony

On 3/27/2012 4:38 PM, Andrew Brygin wrote:
> Hi Anthony,
> 
>  thanks for the review. I have updated the fix with a check for null 
> attributes set:
>  http://cr.openjdk.java.net/~bae/7154047/webrev/
> 
> Thanks,
> Andrew
> 
> On 27.03.2012 16:17, Anthony Petrov wrote:
>> Hi Andrew,
>>
>> At line 160 there's a check of 'attributes' for null. I assume it may 
>> be null. So you should check it for null at line 150, too, to avoid an 
>> NPE. Looks good otherwise (though I'm not an expert in printing code).
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 3/27/2012 4:02 PM, Andrew Brygin wrote:
>>> Hello,
>>>
>>>  could you please review a small fix for CR 7154047?
>>>
>>>  On macosx, the set of printing attributes does not contain
>>>  a SunPageSelection attribute. Due to this, the shared code
>>>  in RasterPrinterJob ignores PargeRanges attribute, that causes
>>>  printing of all pages.
>>>
>>>  Suggested fix just injects the SunPageSelection attribute into
>>>  the set in order to force the shared code take the PargeRanges
>>>  attribute into account.
>>>
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154047
>>> Webrev: http://cr.openjdk.java.net/~bae/7154047/webrev/
>>>
>>> Thanks,
>>> Andrew
>