Request for review 7156191 [macosx] Can't type into applet demos in Pivot

Anton V. Tarasov anton.tarasov at oracle.com
Wed Mar 28 09:24:08 PDT 2012


Now it looks fine for me.

Thanks!
Anton.

On 3/28/12 2:53 PM, Dmitry Cherepanov wrote:
> Anton V. Tarasov wrote:
>> This works for handleWindowFocusEvent(boolean parentWindowActive), 
>> but what about switching focus somewhere inside the browser but 
>> outside the plugin?
>>
>>  100     public void handleFocusEvent(boolean focused) {
>>  101         this.focused = focused;
>>  102         updateOverlayWindowActiveState();
>>  103     }
>>
>>
>>
>> This will call updateOverlayWindowActiveState() where focused==false 
>> and so the EmbeddedFrame won't be notified about deactivation.
>>
>> Also, is it possible to have handleFocusEvent(true) called when the 
>> browser is inactive? If so, the EmbeddedFrame will receive unrelated 
>> notification.
>>
>> Did I get it right?
>
> You're right. Here's the new version of the fix:
>
> http://cr.openjdk.java.net/~dcherepanov/7156191/webrev.1/
>
> I hope that this addresses your concerns.
>
> Thanks,
> Dmitry
>
>



More information about the macosx-port-dev mailing list