[7u6] request for review: 7146550: [macosx] DnD test failure in createCompatibleWritableRaster()

[Artem Ananiev]

On 5/28/2012 1:00 PM, Andrew Brygin wrote:
> Hi Artem,
>
> I have submitted bug 7172180 against AWT in order to track discussed
> clarification for the spec.

Thanks.

Artem

> Thanks,
> Andrew
>
> On 25.05.2012 19:59, Artem Ananiev wrote:
>> Hi, Andrew,
>>
>> thanks for this clarification. I'm fine with the fix then as it makes
>> AWT behave consistently on all the platforms.
>>
>> Could you file a new (likely low priority) bug about startDrag()
>> specification against AWT, please?
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/25/2012 6:22 PM, Andrew Brygin wrote:
>>> Hi Artem,
>>>
>>> the spec does not defines how we should handle the drag image. We
>>> probably can not delay
>>> startDrag() operation in order to prepare the image, because it may take
>>> noticeable time (or
>>> hangs infinitely as a corner case, and the test implements this
>>> scenario). At least, we do
>>> behave in such manner on windows.
>>>
>>> Also, it seems to be logical to put all methods related to CImage
>>> production to CImage.Creator
>>> class. So, there we need to have two ways to convert a toolkit image to
>>> CImage:
>>> * 'immediate': returns null if toolkit image is not ready
>>> * 'normal': prepare toolkit image before conversion
>>>
>>> We likely need some kind of spec clarification for startDrag(), in order
>>> to define how should we
>>> handle toolkit images which are not ready: wait and prepare, silently
>>> ignore, or throw an exception.
>>>
>>> At the moment, this fix just makes our behavior on different platforms a
>>> bit more consistent.
>>>
>>> Thanks,
>>> Andrew
>>>
>>>
>>> On 25.05.2012 17:18, Artem Ananiev wrote:
>>>> Hi, Andrew,
>>>>
>>>> I didn't participate in the fix review for JDK8, so could you explain
>>>> the purpose of that createFromImageImmediately() method in CImage,
>>>> please? Why having createFromImage(), which always waits until the
>>>> image is ready, and additional checks for w > 0 and h > 0 is not
>>>> enough?
>>>>
>>>> Thanks,
>>>>
>>>> Artem
>>>>
>>>> On 5/25/2012 2:23 PM, Andrew Brygin wrote:
>>>>> Hello,
>>>>>
>>>>> could you please review a backport of the fix for 7146550 to 7u6?
>>>>>
>>>>> The fix is almost the same as for jdk8, it just adds helper method
>>>>> imageToArray to CImage class. This method was introduced in jdk8 as
>>>>> a part of the fix for 7148275 ([macosx] setIconImages() not working
>>>>> correctly (distorted icon when minimized)). Note that 7148275 was
>>>>> fixed in 7u4 and 7u6 in a different manner, there seems to be no
>>>>> need for complete backport of the jdk8 revision of the fix for
>>>>> 7148275.
>>>>>
>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146550
>>>>> Jdk8 changeset:
>>>>> http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a2d12ca36eb3
>>>>> Webrev: http://cr.openjdk.java.net/~bae/7146550/7u6/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> Andrew
>>>
>