[8] Review request for 8024926 [macosx] AquaIcon HiDPI support

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Dec 3 08:11:39 PST 2013


   Could you review the updated fix:
     http://cr.openjdk.java.net/~alexsch/8024926/webrev.01/
   - MultiResolutionImage interface is used from the fix 8011059
   - Only icons with resolution 1x and 2x are created.

     The real Mac OS X system icon have more resolutions.
     The full fix requires retrieving and handling all NSImage 
representations. It can be addressed for the next release.

   Thanks,
   Alexandr.

On 10/29/2013 8:47 PM, Alexander Scherbatiy wrote:
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8024926
>   webrev: http://cr.openjdk.java.net/~alexsch/8024926/webrev.00
>
> The fix returns a high resolution system icon in the overridden 
> getScaledInstance(width, height, hints) method.
>
> The fix relies on the fix for the issue JDK-8011059 [macosx] Make JDK 
> demos look perfect on retina displays:
> http://mail.openjdk.java.net/pipermail/awt-dev/2013-October/006133.html
>  - getScaledInstance(width, height, hints) method is used for the 
> image drawing when IMAGE_SCALING hints are enabled
>  - LWCToolkit.ScalableToolkitImage class is public
>
> Thanks,
> Alexandr.
>



More information about the macosx-port-dev mailing list