[8] Request for review: 8003173 [macosx] Fullscreen on Mac leaves an empty rectangle

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Jan 9 05:32:55 PST 2013


Hello,
Please review the fix.
The reason why we have an empty space in the full screen mode is that we 
did not update our insets.
  - I update insets in the deliverMoveResizeEvent not in the 
windowDidEnterFullScreen, in this case animation became more 
smooth(since we update insets just before paint action). So all old 
fullscreen handle methods in CPlatformWindow were removed.
  - LWWindowPeer.updateInsets will post ComponentEvent if insets were 
changed.
  - CGraphicsDevice.setDisplayMode now stores/restores full screen 
window, because otherwise NSView looks shifted on screen.
  - CPlatformView.enterFullScreenMode(): code related to insets was 
removed, since NSVIew uses the whole screen unlike jdk 6.(see related 
changes in CPlatformWindow.enter/exitFullScreenMode)


Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003173
Webrev can be found at: http://cr.openjdk.java.net/~serb/8003173/webrev.00

-- 
Best regards, Sergey.



More information about the macosx-port-dev mailing list