[7u40] Request for review: [macosx] jawt_md.h shipped with jdk is outdated

Anthony Petrov anthony.petrov at oracle.com
Fri May 17 04:38:07 PDT 2013


Hi David,

The fix looks good to me. Only one question:

src/macosx/javavm/export/jni_md.h
>   29 #define JNIEXPORT

Does the empty #define imply that when building a jni lib on Mac, it 
should export all of its symbols by default?

--
best regards,
Anthony

On 05/17/2013 03:53 AM, David DeHaven wrote:
>
> Here's (the start of) a proposed fix for getting the correct jawt_md.h header in the JDK. I already see a couple things that need to be changed, most notably AWTSurfaceLayers.m (possibly others) still imports JavaVM/jawt_md.h, but I want to get this out there and get some feedback on it.
>
> Rather than complicate the build system more than necessary, I just copied jvm_md.h and jni_md.h verbatim from the solaris sources.
>
> Since I'm not a jdk7u-dev committer, I'll need someone (Sergey?) to sponsor this change.
>
> I have not done much testing and still need to dust off the cryptic pile of JPRT notes to kick off a JPRT run.
>
>
> Webrev:
> http://cr.openjdk.java.net/~ddehaven/7181710/jdk.0/
>
> Issue:
> http://bugs.sun.com/view_bug.do?bug_id=7181710
>
> -DrD-
>


More information about the macosx-port-dev mailing list