<AWT Dev> [8] Review request for 8008728 [macosx] Swing. JDialog. Modal dialog goes to background

[Artem Ananiev]

On 9/12/2013 3:45 PM, Sergey Bylokhov wrote:
> Hi, Alexander.
> The fix looks good.
> Can you add additional comments about the new code in the AWTWindow.m.
> It should describe that the native system can bring up the NSWindow to
> the top even if the window is not main, and we should do some things
> manually.

I agree. The fix looks good, but comments in the bug would be very welcome.

Thanks,

Artem

> On 05.09.2013 18:59, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>>   bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008728
>>   webrev: http://cr.openjdk.java.net/~alexsch/8008728/webrev.00
>>
>>   Suppose there are 2 frames and one modal dialog which has the first
>> frame as a parent.
>>
>>   When we click on the second window the canBecomeMainWindow method
>> returns NO (the second window
>>   is disabled because of the modal dialog) and it does not receive the
>> windowDidBecomeMain event.
>>   But Mac OS X system places the second window over the modal dialog.
>>
>>   The fix checks the right order of windows in the canBecomeMainWindow
>> method.
>>
>> Thanks,
>> Alexandr.
>>
>>
>
>