[9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

[Alexander Scherbatiy]

  Hello,

  Could you review the updated fix:
     http://cr.openjdk.java.net/~alexsch/8038113/webrev.02

   - CachableJRSUIIcon explicitly implements Icon interface now
   - getOptimizedImage() method is removed from the CachingScalingIcon 
because NSImage always scales an image to the requested size
   - @Override annotation is added.

  Thanks,
  Alexandr.

On 4/2/2014 4:37 PM, Petr Pchelko wrote:
> Hello, Alexander.
>
> Could you please add the @Override to the paintIcon method.
>
> Also I suggest to reuse the paintIcon in the createIcon.
>
> With best regards. Petr.
>
> On 02.04.2014, at 16:20, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
>
>>   Hello,
>>
>>   Could you review the updated fix:
>>     http://cr.openjdk.java.net/~alexsch/8038113/webrev.01/
>>
>>   The CachableJRSUIIcon creates an image twice: in createImage() and in the AquaPainter.paint() methods.
>>
>>   The fix paints the icon directly from the AquaPainter.paint() method which uses the properly scaled image.
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 3/26/2014 6:15 PM, Alexander Scherbatiy wrote:
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8038113
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8038113/webrev.00
>>>
>>>   MultiResolution image is used to create resolution variants for the JTree icons.
>>>
>>>   The fix assumes that AquaPainter uses the graphics transform for the image size calculation
>>>   an so depends on the fix for issue 8032667 [macosx] Components cannot be rendered in
>>> http://mail.openjdk.java.net/pipermail/awt-dev/2014-March/007370.html
>>>
>>> Thanks,
>>> Alexandr.
>>>