<AWT Dev> [9] Review request for 8033534 Get MultiResolution image from native system

[Alexander Scherbatiy]

   Hello,

   Could you review the updated fix:
       http://cr.openjdk.java.net/~alexsch/8033534/webrev.02/

   This is the same fix. The only difference is that the 
MultiResolutionBufferedImage class is used from the fix JDK-8035069.

   Thanks,
   Alexandr.


On 2/10/2014 7:05 PM, Scott Palmer wrote:
> Just to be clear, "the image representations are chosen to be closest 
> to the requested size" is not accurate.
> This change returns the smallest image representation that is greater 
> than or equal to the requested size.  (Which I believe is the correct 
> thing to do.)
> A smaller image representation may be closer to the requested size, 
> but it makes more sense to return a larger image since scaling down to 
> size should produce better results than scaling up.
>
> Scott
>
>
> On Mon, Feb 10, 2014 at 8:53 AM, Alexander Scherbatiy 
> <alexandr.scherbatiy at oracle.com 
> <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>
>
>     Could you review the updated fix:
>     http://cr.openjdk.java.net/~alexsch/8033534/webrev.01
>     <http://cr.openjdk.java.net/%7Ealexsch/8033534/webrev.01>
>
>      - The image representations are chosen to be closest to the
>     requested size.
>
>       Thanks,
>       Alexandr.
>
>
>     On 2/4/2014 5:00 PM, Sergey Bylokhov wrote:
>
>         Hi, Alexander.
>         I think that getResolutionVariant should return an image which
>         is close as much as possible to the requested size.
>
>         On 04.02.2014 16:42, Alexander Scherbatiy wrote:
>
>
>             Hello,
>
>             Could you review the fix:
>               bug: https://bugs.openjdk.java.net/browse/JDK-8033534
>               webrev:
>             http://cr.openjdk.java.net/~alexsch/8033534/webrev.00
>             <http://cr.openjdk.java.net/%7Ealexsch/8033534/webrev.00>
>
>             - The method that gets a sorted array of NSImage
>             representaion pixel sizes for the given image size is added
>             - A MultiResolution image is created if an NSImage has
>             several representations for the given image size
>
>             Thanks,
>             Alexandr.
>
>
>
>
>