<AWT Dev> [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

[Petr Pchelko]

Hello, Alexander.

SunToolkit:876 size == -1 ? -1 : size 

What’s going on here? Isn’t this equal to just size? 
I believe is’t wrong and the size should be multiplied by 2 somewhere?
If the method is wrong how does the test pass? 

With best regards. Petr.

On May 20, 2014, at 6:32 PM, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:

> 
>  Hello,
> 
>  Could you look at the fix?
> 
>  Thanks,
>  Alexandr.
> 
> On 4/30/2014 6:34 PM, Alexander Scherbatiy wrote:
>> 
>> Hello,
>> 
>> Could you review the fix:
>>  bug: https://bugs.openjdk.java.net/browse/JDK-8040291
>>  webrev: http://cr.openjdk.java.net/~alexsch/8040291/webrev.00
>> 
>> 
>>  The SunToolkit.prepareResolutionVariant() method wraps the base image observer and
>>  passes it to the resolution variant. It leads that the resolution variant notifies
>>  the base image about info changing.
>> 
>>  When the base image is loaded by the MediaTracker and the resolution variant is loaded
>>  first it calls the base image observer and wrongly finishes the base image loading.
>> 
>> 
>>  The fix passes the reduced resolution variant info flags to the base image
>>  so the base image loading is finished only after notifiing by the original base image observer.
>> 
>> 
>> Thanks,
>> Alexandr.
>> 
>