Patch review: fix infinite loop in anonymousClassLoader.checkHostClass

[John Rose]

Good fix, Remi.  Thanks!

Folks, I'm looking forward to a long collaboration with lots of MLVM  
patches.  Let's use the message format described here:
    http://openjdk.java.net/contribute/

At this early point, since sub-projects like anonk are tracked under  
omnibus bugs, you do not need to include a bug number with your  
patch.  Mention the sub-project identifier (anonk) instead of the bug  
number.

Thus, a formal patch submission for Remi's bug would have this  
subject line:
    Subject: [PATCH] anonk: fix infinite loop in  
anonymousClassLoader.checkHostClass

For simple fixes, the formal patch submission and the review request  
be accomplished in the same Email.  For complex fixes or works in  
progress, you might want to ask for review first:
    Subject: Patch review: anonk: fix infinite loop in  
anonymousClassLoader.checkHostClass

If the patch is large, consider submitting it in the form of a link  
to a webrev, like this:
   http://webrev.invokedynamic.info/jrose/6610906/

At present, you are on your own finding web hosting for the webrev.   
Sorry!  I believe this is in the works behind a bunch of other  
OpenJDK infrastructure.

A version of the webrev script is available at:
   http://blogs.sun.com/jcc/entry/webrev_for_openjdk_a_code

There is much more information about being an OpenJDK developer here:
   http://openjdk.java.net/guide/

Finally, if you haven't signed the Sun Contributor Agreement, you'll  
need to do that before the project can incorporate your work.

Best wishes,
-- John

On Apr 18, 2008, at 9:47 AM, Rémi Forax wrote:

> There is a potential infite loop in the current code of the  
> AnonymousClassLoader.
> In checkHostClass, the caller and the callee need to be normalized  
> to their top level classes,
> but outer is not updated in the loop.
> The attachment is a test case to reproduce the bug.
>
> I propose the following patch: