[PATCH] callcc, anonk: anonk will not build unless callcc is pushed also

Charles Oliver Nutter charles.nutter at sun.com
Thu Apr 24 21:44:22 PDT 2008


John Rose wrote:
> On Apr 24, 2008, at 1:23 PM, Charles Oliver Nutter wrote:
>> John Rose wrote:
>>> This is to fix the build bug observed by Selvan and Charlie.
>>> It is a second-order patch (patch on a patch repository).  Apply it 
>>> in davinci/patches/hotspot/.
>>> May I have a reviewer, please?
>>
>> Checking it out now. Should this be built with or without testable 
>> (i.e. are you looking to get a testable patchset working as a result 
>> of this)?
> 
> The default, buildable + testable.
> 
>> I was able to build, but I can't seem to load 
>> java.dyn.AnonymousClassLoader in any code I'm running. That could be 
>> unrelated, perhaps some step I missed?
> 
> Yes, it's unrelated.  Check anonk.txt for an incremental javac command 
> plus bootclasspath stuff.  That's what I've been using to start with, 
> just as a matter of taste.

Ahh, that's the step I was missing. Thanks. It loads and constructs now, 
so I can continue :)

> So, I'll count your build success as a review.  (Unless you have more 
> review comments? :-)

None at all!

> We'll tweak the JDK build shortly if necessary.  (Remi, did you have to 
> take special action to get java.dyn.* into rt.jar?)
> 
> -- John
> 




More information about the mlvm-dev mailing list