meth review

[Rémi Forax]

I've done a more deep review of the code.
Two codes are weird :
MethodType.java, line 155
        if (!trusted)
            // defensively copy the array passed in by the user
            ptypes = ptypes.clone();

ptypes is not used after this line.
I think this test should be moved before the creation of mt1
(before line 146).

MH.java, line 234
static void setVMDataArgSlot(MH self, int argSlot) {
        long index = self.vmdata >> 32;
        self.vmdata = (index << 32) | (argSlot << 32 >>> 32);
}

knowing that argSlot is an int, I don't understand 'argSlot << 32'.

cheers,
Rémi