Ask for a patch review: CallSite.target is not volatile

Rémi Forax forax at univ-mlv.fr
Fri Apr 24 05:12:22 PDT 2009


John Rose a écrit :
> I'm gathering up issues from old mail, and found the incomplete 
> exchange below on the mlvm dev list.
>
> I've followed your advice and removed the "protected" keyword from 
> CallSite fields.  The accessors are sufficient.
>
> I'm also going to remove the single-inheritance mixin pattern which 
> you objected to, since IBM has also objected to it (on the EG). 
>  Basically, I'm going to have the JVM special-case MethodHandle 
> instead of a superclass sun.dyn.MethodHandleImpl.
Great,
I always had a bad feeling about this design.
>
> (My English teacher in high school used to say, "kill your darlings", 
> meaning that, if you have a bit of writing you think particularly 
> clever, you probably need to edit it.)

I've already heard this expression about a piece of code, but I'm not 
able to remember where and when.
Nevertheless, it seems to be a good principle.
>
> I've raised the issues about target invalidation with the EG.  Are 
> there other issues in the exchange below that we should call out?
No, the main purpose of that thread was volatile target and invalidation
>
> Thanks,
> -- John
cheers,
Rémi



More information about the mlvm-dev mailing list