applying patches doesn't seem to work

[alan yung]

It worked, and I could successfully apply the patches.and, yes it would have
helped! Thanks.

Now I have different build problem - build fails with error messages in
hotspot directory.
The errors look like following:  (the machine is windows XP)

C:\cygwin\home\alan\davinci\sources\hotspot\src\share\vm\utilities\growableArray.hpp(132)
: error C2220: warn
ing treat
d as error - no 'object' file generated

 C:\cygwin\home\alan\davinci\sources\hotspot\src\share\vm\utilities\growableArray.hpp(130)
: while com
piling cl
ss template member function 'GrowableArray<E>::GrowableArray(Thread *,int)'
        with
        [
            E=MethodHandleWalker::SlotState
        ]

 c:\cygwin\home\alan\davinci\sources\hotspot\src\share\vm\prims\methodHandleWalk.hpp(121)
: see refere
nce to cl
ss template instantiation 'GrowableArray<E>' being compiled
        with
        [
            E=MethodHandleWalker::SlotState
        ]
C:\cygwin\home\alan\davinci\sources\hotspot\src\share\vm\utilities\growableArray.hpp(132)
: warning C4345: be
havior ch
nge: an object of POD type constructed with an initializer of the form ()
will be default-initialized
C:\cygwin\home\alan\davinci\sources\hotspot\src\share\vm\utilities\growableArray.hpp(316)
: warning C4345: be
havior ch
nge: an object of POD type constructed with an initializer of the form ()
will be default-initialized

 C:\cygwin\home\alan\davinci\sources\hotspot\src\share\vm\utilities\growableArray.hpp(307)
: while com
piling cl
ss template member function 'void GrowableArray<E>::grow(int)'
        with
        [
            E=MethodHandleWalker::SlotState
        ]
methodHandles.cpp
nativeLookup.cpp
perf.cpp
privilegedStack.cpp
unsafe.cpp
Generating Code...
NMAKE : fatal error U1077: 'C:\cygwin\home\alan\dtools\msvs\VC\bin\cl.exe' :
return code '0x2'
Stop.
NMAKE : fatal error U1077: 'cd' : return code '0x2'
Stop.
NMAKE : fatal error U1077:
'C:\cygwin\home\alan\dtools\msvs\VC\bin\nmake.EXE' : return code '0x2'
Stop.
make[1]: *** [generic_build2] Error 2
make[1]: Leaving directory `/home/alan/davinci/sources/hotspot/make'
make: *** [jvmg] Error 2

Any help?  (I'm posting it here since it builds openjdk7 without patches)

Thanks,

alan

On Wed, Sep 30, 2009 at 2:13 PM, John Rose <John.Rose at sun.com> wrote:

> Alan, enclosed is a new section in the README called "Trouble Shooting".
>  Would you mind testing it on your setup, please?  Would it have helped with
> your difficulty?
>
> Thanks,
> -- John
>
> == Trouble Shooting ==
>
> To verify that the current release is properly checked out, you can use
> Mercurial commands like these in the source directory:
>        cd davinci/sources/hotspot
>        hg qpop -a  # following commands assume no patches active
>        hg parent  # output should include the 12-digit hash of the working
> version
>        R_CUR=$(hg parent --template '{node|short}\n')
>        head -1 < .hg/patches/series # header comment describes main base
> revision
>        R_REQ=$(head -1 < .hg/patches/series | awk '{print $4}')  # should
> be main base revision
>        [ $R_REQ = $R_CUR ] || echo "*** WRONG PATCH BASE"
>
> The 'checkout' command can be used to reset a clean source repository to
> the base revision required for patches:
>        hg qpop -a  # following commands assume no patches active
>        hg checkout $R_REQ
>        R_CUR=$(hg parent --template '{node|short}\n')
>        [ $R_REQ = $R_CUR ] || echo "*** CHECKOUT FAILED"
>        hg qselect buildable testable $R_CUR
>        hg qpush -a
>        R_QPAR=$(hg log -r qparent --template '{node|short}\n')
>        [ $R_REQ = $R_QPAR ] || echo "*** QUEUE PUSH FAILED"
>
>
>
> On Sep 30, 2009, at 12:55 AM, alan yung wrote:
>
>  Actually, I didn't apply the patches correctly.
>>
>> Now when I tried to apply the patches, it shows many error messages, but
>> it did apply (at least) some patches successfully.
>>
>> My question is, do the patches apply successfully in current head
>> revision?
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/mlvm-dev/attachments/20091001/2a410c45/attachment.html