Surinx + backport

Rémi Forax forax at univ-mlv.fr
Fri Sep 11 15:35:15 PDT 2009


Le 11/09/2009 11:42, Christian Thalinger a écrit :
> Rémi Forax wrote:
>    
>> Before trying to apply the inlining patch, is there a reason why it is
>> guarded by testable ?
>>      
> Not really, it's working quite good.  But we still have these GC issues,
> which also apply to the compiler patch... :-/
>
> -- Christian
>    

Christian,
the inlining patch currently doesn't work :(

in methodHandleWalk.hpp (line 322) :

   int cpool_oop_reference_put(int tag, int first_index, int second_index) {
     if (index == 0)  return 0;   // this line doesn't compile
     ConstantValue* cv = new ConstantValue(tag, first_index, second_index);
     return _constants.append(cv);
   }

I think it should be:

   int cpool_oop_reference_put(int tag, int first_index, int second_index) {
     if (first_index == 0 && second_index == 0)  return 0;
     ConstantValue* cv = new ConstantValue(tag, first_index, second_index);
     return _constants.append(cv);
   }

Rémi


More information about the mlvm-dev mailing list