ValueConversion.unbox* fixes(?)

Christian Thalinger christian.thalinger at oracle.com
Fri Nov 12 05:42:13 PST 2010


On Nov 12, 2010, at 2:35 PM, Rémi Forax wrote:
>  Le 12/11/2010 12:26, Christian Thalinger a écrit :
>> As I have already said, I'm not expert here but these changes let all
>> tests of this testcase pass:
>>
>> http://cr.openjdk.java.net/~twisti/6998541/webrev.00/test/compiler/6998541/Test6998541.java.html
>>
>> I'm not sure if the assumption is correct that every non-zero
>> primitive value is a boolean true.
>>
>> John, Remi, I'd like your opinion on that.
>>
>> -- Christian
>
> Christian,
> methods unboxRaw call unbox versions, so you have also changed
> the semantics of all methods unboxRaw which seems a bad idea.


Yeah, I'm also a bit worried about that.  I think I leave that up to  
John to fix it properly.

-- Christian


More information about the mlvm-dev mailing list