Request for reviews (S): 7001363: java/dyn/InvokeDynamic should not be a well-known class in the JVM

[Vladimir Kozlov]

Looks good.

Vladimir

Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/7001363/webrev.01/
> 
> 7001363: java/dyn/InvokeDynamic should not be a well-known class in the JVM
> Summary: Because of the removal of language support, the JDK 7 API for JSR 292 no longer includes a public class named java/dyn/InvokeDynamic.
> Reviewed-by:
> 
> Because of the removal of language support, the JDK 7 API for JSR 292
> no longer includes a public class named java/dyn/InvokeDynamic.
> 
> However, the JVM uses java/dyn/InvokeDynamic (arbitrarily) as a marker
> class for invokedynamic instructions. This practice needs to change,
> and the class may then be removed from the JDK.
> 
> John already reviewed the changes, I'm just sending an official webrev for completeness.  Please feel free to review it too!
> 
> 
> Begin forwarded message:
>> From: John Rose <john.r.rose at oracle.com>
>> Date: November 30, 2010 12:52:41 AM GMT+01:00
>> To: Christian Thalinger <christian.thalinger at oracle.com>
>> Subject: Re: 7001363: java/dyn/InvokeDynamic should not be a well-known class in the JVM
>>
>> On Nov 29, 2010, at 7:08 AM, Christian Thalinger wrote:
>>
>>> On Nov 19, 2010, at 8:44 AM, John Rose wrote:
>>>> Can I hand you this one?
>>>
>>> It's not completely clear to me what we have to remove.  As far as I understand it invokedynamic instructions should still work but all references to java/dyn/InvokeDynamic should disappear.  This is preliminary webrev:
>>>
>>> http://cr.openjdk.java.net/~twisti/7001363/webrev.00/
>>>
>>> These changes do exactly that.  I can still run invokedynamic programs but the InvokeDynamic class is not referenced and loaded anymore.
>> Reviewed.  Looks good.  (You can CC this to hotspot-compiler-dev if you want.)  -- John
> 
>