hg: mlvm/mlvm/jdk: meth-lazy: merged BMH factory into BMH, added test for primitive parameter binding

[Rémi Forax]

On 07/12/2012 12:10 AM, Michael Haupt wrote:
> Hi Remy,
>
> Am 11.07.2012 um 22:48 schrieb Rémi Forax:
>> Hi Mickael,
>> some minor comments,
>> makeSignature should use a StringBuilder and not a StringBuffer.
>
> good point, thanks!
>
>> ans I don't think generateConcreteBMHClass needs to return a Class<?
>> extends BoundMethodHandle>,
>> a Class<?> seems enough so the cast near the end of the method can be
>> removed.
>
> I'd like to keep that to make really clear what Class type instances 
> are expected.
> (There are places where Class<?> would just feel very wrong.)

but the cast seems wrong to me because this one is not enforced by the VM
so if there is a bug, you may lure the reader of the code.
I think a doc comment is better here.

Or perhaps you can use asSubClass() ?

>
> Best,
>
> Michael

regards,
Rémi