RFR(S) : 8039953 : [TESTBUG] Timeout java/lang/invoke/MethodHandles/CatchExceptionTest.java

[Igor Ignatyev]

http://cr.openjdk.java.net/~iignatyev/8039953/webrev.01/

to have TimeLimitedRunner more general, I've added 'factor' argument to 
its ctor.

Thanks,
Igor

On 12/01/2014 02:39 PM, Igor Ignatyev wrote:
> Paul/Vladimir,
>
> thanks for review.
>
> On 12/01/2014 01:29 PM, Vladimir Ivanov wrote:
>> On 12/1/14, 2:46 PM, Paul Sandoz wrote:
>>> Hi Igor,
>>>
>>> This looks ok.
>>>
>>> I like how you have factored out things into TimeLimitedRunner. Do you
>>> plan in a future patch to update lambda form test code that uses
>>> similar functionality?
> yes, I plan to update existing tests as well as backport
> TimeLimitedRunner into hotspot and refactor hotspot tests.
>>
>>> Is the adjustment "timeout *= 0.9" necessary? does reduction by 10%
>>> make a difference?
>> It improves test stability (on highly loaded hosts and in heavy testing
>> modes), but I doubt it's the right way to go. I'd measure actual startup
>> time and adjust timeout value, but it seems jtreg doesn't provide such
>> info.
>>
>> So, I'd leave it as is for now, file an RFE on jtreg and rewrite this
>> logic once support in jtreg is implemented.
> Yes, I also don't think that it's a right way, but it's the best that we
> can do now. Even if jtreg provides startup time, it won't help us w/ vm
> shutdown time estimation.
>>
>> Otherwise, looks good.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>>>
>>> Paul.
>>>
>>> On Nov 29, 2014, at 5:36 PM, Igor Ignatyev <igor.ignatyev at oracle.com>
>>> wrote:
>>>
>>>> http://cr.openjdk.java.net/~iignatyev/8039953/webrev.00
>>>> 98 lines changed: 93 ins; 3 del; 2 mod;
>>>>
>>>> Hi all,
>>>>
>>>> Please review the patch:
>>>>
>>>> Problem:
>>>> on some configurations,
>>>> java/lang/invoke/MethodHandles/CatchExceptionTest.java can timeout
>>>> before all test cases are run
>>>>
>>>> Fix:
>>>> interrupt test execution if it's not enough time to continue
>>>>
>>>> bug : https://bugs.openjdk.java.net/browse/JDK-8039953
>>>> changes in testlibrary :
>>>> https://bugs.openjdk.java.net/browse/JDK-8066191
>>>> testing: locally
>>>>
>>>> --
>>>> Igor
>>>
> _______________________________________________
> mlvm-dev mailing list
> mlvm-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev