[9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke

[Paul Sandoz]

On Jul 10, 2014, at 1:57 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

> http://cr.openjdk.java.net/~vlivanov/8049555/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8049555
> 
> Code cleanup:
> - moved varargsArray(Class,int) & varargsArray(int) from sun.invoke.util.ValueConversions to java.lang.invoke.MethodHandleImpl;
> - removed unused varargsList(int);

MethodHandleImpl.convertArrayElements (copied over from sun.invoke.util.ValueConversions) is also not used, do you wanna keep then one?


> - extracted relevant tests from ValueConversionsTest to VarargsArrayTest.
> 

That's an interesting trick to get things working on the bootclasspath:

  36  * @run main ClassFileInstaller java.lang.invoke.VarargsArrayTest
  37  *                              java.lang.invoke.VarargsArrayTest$1

Where does "java.lang.invoke.VarargsArrayTest$1" comes from? If it does not exist i would presume an NPE would occur causing the test to fail on setup?

Paul.


> Testing: regression tests (jdk/java/lang/invoke, jdk/java/util/streams), nashorn, octane.
> 
> Thanks!
> 
> Best regards,
> Vladimir Ivanov
> _______________________________________________
> mlvm-dev mailing list
> mlvm-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/mlvm-dev/attachments/20140710/a7acff30/signature-0001.asc>