[9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

[Konstantin Shefov]

Vladimir, thanks for reviewing

I have updated the webrev: 
http://cr.openjdk.java.net/~kshefov/8059070/webrev.02
I have added DEFAULT_TEST_TIMEOUT constant to Utils class.

-Konstantin

On 10.11.2014 14:33, Vladimir Ivanov wrote:
> Kontantin, sorry for the late response.
>
> In general, the fix looks good.
>
> I'd move timeout computation logic to Utils:
> +    private static final long TIMEOUT = 
> Utils.adjustTimeout(TimeUnit.SECONDS.toMillis(120));
>
> Default value (120s) isn't specific to the tests, but an 
> implementation detail of jtreg.
>
> Best regards,
> Vladimir Ivanov
>
> On 11/7/14, 2:22 PM, Konstantin Shefov wrote:
>> Gently reminder
>>
>> 29.10.2014 17:25, Konstantin Shefov пишет:
>>> Please, review a test bug fix.
>>> http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
>>>
>>> -Konstantin
>>>
>>> On 27.10.2014 13:16, Konstantin Shefov wrote:
>>>> Kindly reminder
>>>>
>>>> On 23.10.2014 19:04, Paul Sandoz wrote:
>>>>> On Oct 23, 2014, at 1:25 PM, Konstantin Shefov
>>>>> <konstantin.shefov at oracle.com> wrote:
>>>>>> Gently reminder
>>>>>>
>>>>>> On 17.10.2014 13:38, Konstantin Shefov wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> I have updated the webrev:
>>>>>>> http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
>>>>>>>
>>>>> +1
>>>>>
>>>>> Sorry for the delay,
>>>>> Paul.
>>>>
>>>
>>