[9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineError
Konstantin Shefov
konstantin.shefov at oracle.com
Fri Oct 10 17:31:02 UTC 2014
Thanks for reviewing! Pushed.
-Konstantin
10.10.2014 19:06, Vladimir Ivanov пишет:
> Looks good.
>
> Best regards,
> Vladimir Ivanov
>
> On 10/9/14, 12:44 PM, Konstantin Shefov wrote:
>> Hi,
>>
>> I have updated the webrev to take into account the JDK 9 new feature
>> with segmented code cache.
>> http://cr.openjdk.java.net/~kshefov/8058733/webrev.02
>>
>> Please, review.
>>
>> -Konstantin
>>
>> On 08.10.2014 21:25, Joe Darcy wrote:
>>> Hello,
>>>
>>> I approve this change going into jdk9/dev contingent on the failing
>>> tests passing as modified.
>>>
>>> Thanks,
>>>
>>> -Joe
>>>
>>> On 10/8/2014 7:38 AM, Konstantin Shefov wrote:
>>>> Daniel,
>>>> Thanks for your comment
>>>>
>>>> Here is the updated webrev:
>>>> http://cr.openjdk.java.net/~kshefov/8058733/webrev.01
>>>>
>>>> -Konstantin
>>>>
>>>> On 08.10.2014 17:25, Daniel Fuchs wrote:
>>>>> Hi Konstantin,
>>>>>
>>>>> I'm not qualified as a (R)eviewer for changes in this area,
>>>>> but I believe you can do:
>>>>>
>>>>> HotSpotDiagnosticMXBean mbean =
>>>>> ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class);
>>>>>
>>>>> to get a handle on the MBean. You don't need to go through
>>>>> the MBeanServer and newPlatformMXBeanProxy stuff...
>>>>>
>>>>> best regards,
>>>>>
>>>>> -- daniel
>>>>>
>>>>> On 08/10/14 15:15, Konstantin Shefov wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review the test bug fix
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8058733
>>>>>> Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> -Konstantin
>>>>>
>>>>
>>>
>>
More information about the mlvm-dev
mailing list