[9] RFR (L): 8057042: LambdaFormEditor: derive new LFs from a base LF

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Wed Sep 10 13:31:55 UTC 2014


Peter,

>>> I think line 341 is wrong. It should be:
>>>
>>>      if (k == null) break;
>>>
>>> shouldn't it?
>> Good catch! Fixed.
>>
>
> I think it can even be removed or replaced with something like:
>
>      assert k != null;
>
> ...since null entry in array is not possible in this situation -
> promotion to CHM happens only when array is full.
Good point. I've removed the check altogether.
CHM.put() throws NPE for null key/value anyway.

Updated webrev inplace:
http://cr.openjdk.java.net/~vlivanov/8057042/webrev.00/

Best regards,
Vladimir Ivanov


More information about the mlvm-dev mailing list