[9] RFR (XXS): 8077054: DMH LFs should be customizeable

[Vladimir Ivanov]

Thanks for review, John!

Yes, it increases the number of customized LFs, but not significantly.

Octane/Nashorn (before/after):
   Box2D:                 90 / 127
   CodeLoad.testClosure:  40 /  44
   CodeLoad.testJQuery:   93 / 102
   Crypto:                12 /  23
   DeltaBlue:              5 /  17
   EarleyBoyer:           36 /  43
   Gameboy:              365 / 438
   Mandreel:              54 /  58
   NavierStokes:           5 /  10
   PdfJS:                614 / 664
   Raytrace:              32 /  39
   Regexp:                16 /  22
   Richards:               5 /  15
   Splay:                  5 /   9

Best regards,
Vladimir Ivanov

On 4/9/15 9:50 PM, John Rose wrote:
> Looks good.  Would you please also check the number of distinct LFs compiled when running standard benchmarks?  (With and without the change.)  The number should go up, but only slightly.
>
> Thanks!
> — John
>
> On Apr 9, 2015, at 11:44 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~vlivanov/8077054/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8077054
>>
>> It's a followup fix for JDK-8069591 [1].
>>
>> As Charlie observed, it's important to customize DirectMethodHandles as well. Otherwise, additional frame for DMH LambdaForm is created and it causes observable peak performance regression in some situations (e.g. JRuby9K).
>>
>> Testing: manual (microbenchmark, compilation log inspection).
>>
>> Thanks!
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8069591
>>      "Customize LambdaForms which are invoked using
>>       MH.invoke/invokeExact"
>> _______________________________________________
>> mlvm-dev mailing list
>> mlvm-dev at openjdk.java.net
>> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>
> _______________________________________________
> mlvm-dev mailing list
> mlvm-dev at openjdk.java.net
> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
>