git: openjdk/mobile: 6313903: Thread.sleep(3) might wake up immediately on windows

Johan Vos johan.vos at gluonhq.com
Sun Sep 8 15:15:17 UTC 2019


Hi Bob,

The master branch of the jdk/mobile repository is kept in sync with jdk/jdk
(one-way though, changes from jdk/jdk propagate to jdk/mobile but not the
other way round, although that should be the end goal).

Doing so, we are immediately notified in case a change in jdk/jdk breaks
jdk/mobile. This prevents that we're constantly lagging behind to jdk/jdk.

Hence, the jdk/mobile master branch can have changes coming from 2 ways:
1. auto-synced from the upstream jdk/jdk repository
2. PR's coming from mobile-specific changes.

I asked the Skara team to send changes to the repository in general to a
separate mailinglist.

I agree changes from the second way are more relevant to this mailinglist,
so we have a few options:

1. Don't send any notifications at all
2. Send all notifications to mobile-dev
3. Send all notifications to mobile-changes (a new list)
4. Send upstream changes to mobile-changes, and mobile changes (via PR's)
to mobile-dev
5. Don't send notifications from upstream at all, and send mobile change
notifications to mobile-changes

I believe that in the past, mobile-specific changes were sent to this
mailing list (mobile-dev), so it makes sense to keep doing this. However,
I'm not sure the Skara tools currently allow this splitted behavior on
changes. Hence, to be on the safe side for now, I would vote for option 3.

Thoughts?

- Johan

On Sun, Sep 8, 2019 at 3:26 PM Bob Vandette <bob.vandette at oracle.com> wrote:

> Johan,
>
> It looks like I’m getting notifications of mainline jdk changes not
> related to the mobile project.
> Was this intentional?
>
> Here’s an example:
>
>
>
> Bob.
>
> > On Sep 8, 2019, at 3:43 AM, Johan Vos <johan.vos at gluonhq.com> wrote:
> >
> > I'll ask the Skara team if the notifications can be sent to another
> > mailinglist. We have something similar with openjfx where the commit
> > notifications are sent to openfx-notifications and the technical
> > discussions are sent to openjfx-dev.
> >
> > - Johan
> >
> > On Sun, Sep 8, 2019 at 6:33 AM David Holmes <david.holmes at oracle.com>
> wrote:
> >
> >> On 8/09/2019 2:09 pm, thelma reynoso wrote:
> >>> Can we remove this please I never set this up
> >>
> >> If you mean the notifications that would be up to whomever added them -
> >> which I assume would be Johan.
> >>
> >> David
> >>
> >>> On Fri, Sep 6, 2019 at 7:26 PM David Holmes <david.holmes at oracle.com
> >>> <mailto:david.holmes at oracle.com>> wrote:
> >>>
> >>>    On 7/09/2019 2:40 am, thelma reynoso wrote:
> >>>> What is this
> >>>
> >>>    Are you asking about this patch or these emails in general?
> >>>
> >>>    mobile-dev has started using a GIT repository and it seems it has
> >> been
> >>>    setup to be updated whenever a changeset is pushed to the mainline
> >>>    jdk/jdk repository - and GIT has been configured to send out these
> >>>    notification emails to the mobile-dev mailing list.
> >>>
> >>>    Cheers,
> >>>    David
> >>>
> >>>> On Tue, Sep 3, 2019 at 11:55 PM duke <duke at openjdk.java.net
> >>>    <mailto:duke at openjdk.java.net>> wrote:
> >>>>
> >>>>> Changeset: 99c17fbf
> >>>>> Author:    David Holmes <dholmes at openjdk.org
> >>>    <mailto:dholmes at openjdk.org>>
> >>>>> Date:      2019-09-03 23:42:06 +0000
> >>>>> URL: https://github.com/openjdk/mobile/commit/99c17fbf
> >>>>>
> >>>>> 6313903: Thread.sleep(3) might wake up immediately on windows
> >>>>>
> >>>>> Reviewed-by: rehn, dcubed, rriggs
> >>>>>
> >>>>> ! src/hotspot/os/posix/os_posix.cpp
> >>>>> ! src/hotspot/os/windows/os_windows.cpp
> >>>>> ! src/hotspot/share/runtime/os.cpp
> >>>>>
> >>>>>
> >>>>> --
> >>>> iPhone 7b
> >>>>
> >>>
> >>> --
> >>> iPhone 7b
> >>
>
>


More information about the mobile-dev mailing list