[Rev 01] RFR: 8244947: fix ios/android build for static libs

[Magnus Ihse Bursie]

On Wed, 13 May 2020 19:40:01 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> Add build logic for building static-libs-image for ios and android
>> 
>> Fix for JDK-8244947
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove typo

Changes requested by ihse (Reviewer).

make/common/JdkNativeCompilation.gmk line 69:

> 68:
> 69:
> 70: # Find a library. Used for declaring dependencies on libraries in different

You can remove the extra line breaks that appeared here.

make/common/JdkNativeCompilation.gmk line 55:

> 54: endif
> 55:
> 56: FindSrcDirsForLib += \

This needs some work. First of all, FindSrcDirsForLib should only be added to using +=, since the variable can have a
prior value from the custom (closed) file. Secondly, later down,  FindSrcDirsForLib will have the "standard"
directories appended, so no need to duplicate that here. Thirdly, order is important. If two files with the same name
is present in the code base, only one will be selected, and the order of the directories in  FindSrcDirsForLib will
determine the priorites. This code basically says "first ios, then unix, then macosx" or "first android, then unix,
then linux". If this order is correct, then a better way to accomplish this is to just append macosx or linux *after*
the normal assignment to  FindSrcDirsForLib below.

-------------

PR: https://git.openjdk.java.net/mobile/pull/4