From ihse at openjdk.org Wed Apr 10 13:19:18 2024 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Wed, 10 Apr 2024 13:19:18 GMT Subject: RFR: 8255240: Mobile builds need to exclude some modules [v3] In-Reply-To: References:

Message-ID: On Wed, 27 Mar 2024 17:36:48 GMT, Johan Vos wrote: >> This PR enables to build the static libs for ios/android for the native code in most of the modules. >> It also adds GA scripts to build those libs on Android and iOS. >> Note that building hotspot is disabled by this PR. > > Johan Vos has updated the pull request incrementally with one additional commit since the last revision: > > re-enable gensrc for X11 on Android > fix whitespace issue I guess this looks good enough now, but the PR/JBS issue title does not seem to correlate at all to what the code does... ------------- Marked as reviewed by ihse (no project role). PR Review: https://git.openjdk.org/mobile/pull/20#pullrequestreview-1991667123 From jvos at openjdk.org Sun Apr 14 07:09:17 2024 From: jvos at openjdk.org (Johan Vos) Date: Sun, 14 Apr 2024 07:09:17 GMT Subject: RFR: 8255240: Mobile builds need to exclude some modules [v4] In-Reply-To: References: Message-ID: > This PR enables to build the static libs for ios/android for the native code in most of the modules. > It also adds GA scripts to build those libs on Android and iOS. > Note that building hotspot is disabled by this PR. Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Merge branch 'master' into staticlibs - re-enable gensrc for X11 on Android fix whitespace issue - Process reviewer comments - Merge branch 'master' into staticlibs - When building for ios, deal with non-supported @objectfilenames (similar to macos and aix) - Merge branch 'master' into minimal-android-23 Fix conflict related to major changes in NativeCompilation.gmk - Add android workflow (#2) * Add android build * fix env variable use * fix condition * update conf and build for android * add config name * remove build jdk * update id * fix command * add ls to debug * fix build command * update conf name * update directory name * remove ${{ }} to fix condition * do not remove bundle for android * add debug * add debug * do not build debug * s/x64/aarch64 * add debug logs * fix condition * create only release * build on push * add ios build * fix platform name * download cups from source * fix command * skip running make for product-bundles and test-bundles * update upload to support ios static - Add required ios changes for building static libs. Add sample configure script for ios - Changes required to build static libs for Android with JDK 23-ea ------------- Changes: https://git.openjdk.org/mobile/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=mobile&pr=20&range=03 Stats: 426 lines in 17 files changed: 347 ins; 2 del; 77 mod Patch: https://git.openjdk.org/mobile/pull/20.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/20/head:pull/20 PR: https://git.openjdk.org/mobile/pull/20 From johan.vos at gluonhq.com Thu Apr 18 07:11:53 2024 From: johan.vos at gluonhq.com (Johan Vos) Date: Thu, 18 Apr 2024 09:11:53 +0200 Subject: CFV: New Mobile Reviewer: Magnus Ihse Bursie Message-ID: I hereby nominate Magnus Ihse Bursie to Mobile Reviewer. Magnus is working in the Java Engineering Infrastructure team at Oracle. He is building the tools needed to make development of the Java/OpenJDK software efficient and productive in a heterogeneous environment of multiple platforms. Votes are due by May 2, 2024 Only current Mobile Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Johan Vos [1] https://openjdk.org/census [2] https://openjdk.org/projects/#reviewer-vote -------------- next part -------------- An HTML attachment was scrubbed... URL: From johan.vos at gluonhq.com Thu Apr 18 07:38:50 2024 From: johan.vos at gluonhq.com (Johan Vos) Date: Thu, 18 Apr 2024 09:38:50 +0200 Subject: CFV: New Mobile Reviewer: Magnus Ihse Bursie In-Reply-To: References: Message-ID: Vote: YES - Johan On Thu, Apr 18, 2024 at 9:11?AM Johan Vos wrote: > I hereby nominate Magnus Ihse Bursie to Mobile Reviewer. > > Magnus is working in the Java Engineering Infrastructure team at Oracle. > He is building the tools needed to make development of the Java/OpenJDK > software efficient and productive in a heterogeneous environment of > multiple platforms. > > Votes are due by May 2, 2024 > > Only current Mobile Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Johan Vos > [1] https://openjdk.org/census > [2] https://openjdk.org/projects/#reviewer-vote > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ihse at openjdk.org Thu Apr 18 10:42:10 2024 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Thu, 18 Apr 2024 10:42:10 GMT Subject: RFR: 8255240: Mobile builds need to exclude some modules [v4] In-Reply-To: References:

Message-ID: On Sun, 14 Apr 2024 07:09:17 GMT, Johan Vos wrote: >> This PR enables to build the static libs for ios/android for the native code in most of the modules. >> It also adds GA scripts to build those libs on Android and iOS. >> Note that building hotspot is disabled by this PR. > > Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: > > - Merge branch 'master' into staticlibs > - re-enable gensrc for X11 on Android > fix whitespace issue > - Process reviewer comments > - Merge branch 'master' into staticlibs > - When building for ios, deal with non-supported @objectfilenames (similar to macos and aix) > - Merge branch 'master' into minimal-android-23 > Fix conflict related to major changes in NativeCompilation.gmk > - Add android workflow (#2) > > * Add android build > > * fix env variable use > > * fix condition > > * update conf and build for android > > * add config name > > * remove build jdk > > * update id > > * fix command > > * add ls to debug > > * fix build command > > * update conf name > > * update directory name > > * remove ${{ }} to fix condition > > * do not remove bundle for android > > * add debug > > * add debug > > * do not build debug > > * s/x64/aarch64 > > * add debug logs > > * fix condition > > * create only release > > * build on push > > * add ios build > > * fix platform name > > * download cups from source > > * fix command > > * skip running make for product-bundles and test-bundles > > * update upload to support ios static > - Add required ios changes for building static libs. > Add sample configure script for ios > - Changes required to build static libs for Android with JDK 23-ea .github/actions/do-build/action.yml line 44: > 42: - name: 'Build Android or iOS' > 43: id: build-android-ios > 44: run: | This is a hack, put in the wrong place. See below for a better solution. .github/workflows/build-android-static.yml line 131: > 129: uses: ./.github/actions/do-build > 130: with: > 131: make-target: '${{ inputs.make-target }} ${{ inputs.make-arguments }}' Suggestion: make-target: 'static-libs-image ${{ inputs.make-arguments }}' Then you will not need the change in do-build/action.yml ------------- PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1570469781 PR Review Comment: https://git.openjdk.org/mobile/pull/20#discussion_r1570469205 From david.holmes at oracle.com Tue Apr 23 02:24:02 2024 From: david.holmes at oracle.com (David Holmes) Date: Tue, 23 Apr 2024 12:24:02 +1000 Subject: CFV: New Mobile Reviewer: Magnus Ihse Bursie In-Reply-To: References: Message-ID: <7b924d4e-f17c-43da-8e81-fb875ffb5a61@oracle.com> Vote: yes (I think I am the only active Reviewer of this project left.) David On 18/04/2024 5:11 pm, Johan Vos wrote: > I hereby nominate Magnus Ihse Bursie to Mobile Reviewer. > > Magnus is working in the Java Engineering Infrastructure team at Oracle. > He is?building the tools needed to make development of the Java/OpenJDK > software efficient and productive in a heterogeneous environment of > multiple platforms. > > Votes are due by May 2, 2024 > > Only current Mobile Reviewers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Johan Vos > [1] https://openjdk.org/census > [2] https://openjdk.org/projects/#reviewer-vote > From duke at openjdk.org Thu Apr 25 12:50:24 2024 From: duke at openjdk.org (J. Duke) Date: Thu, 25 Apr 2024 12:50:24 GMT Subject: RFR: Merge jdk:master Message-ID: Hi all, this is an _automatically_ generated pull request to notify you that there are 337 commits from the branch `jdk:master`that can **not** be merged into the branch `master`: The following files contains merge conflicts: - make/autoconf/flags-cflags.m4 - make/autoconf/toolchain.m4 - make/common/JdkNativeCompilation.gmk All Committers in this [project](https://openjdk.org/census#mobile) have access to my [personal fork](https://github.com/openjdk-bots/mobile) and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. The below commands should be run in a local clone of your [personal fork](https://wiki.openjdk.org/display/skara#Skara-Personalforks) of the [openjdk/mobile](https://github.com/openjdk/mobile) repository. # Ensure target branch is up to date $ git checkout master $ git pull https://github.com/openjdk/mobile.git master # Fetch and checkout the branch for this pull request $ git fetch https://github.com/openjdk-bots/mobile.git +3:openjdk-bot-3 $ git checkout openjdk-bot-3 # Merge the target branch $ git merge master When you have resolved the conflicts resulting from the `git merge` command above, run the following commands to create a merge commit: $ git add paths/to/files/with/conflicts $ git commit -m 'Merge jdk:master' When you have created the merge commit, run the following command to push the merge commit to this pull request: $ git push https://github.com/openjdk-bots/mobile.git openjdk-bot-3:3 _Note_: if you are using SSH to push commits to GitHub, then change the URL in the above `git push` command accordingly. Thanks, J. Duke ------------- Commit messages: - Merge jdk:master - 8244504: C2: refactor counted loop code in preparation for long counted loop - 8230827: javac gives inappropriate warning about potentially ambiguous methods - 8245786: Scope is wrong for ClassTree representing record - 8246027: Minimal fastdebug build broken after JDK-8245801 - 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js - 8243936: NonWriteable system properties are actually writeable - Added tag jdk-15+25 for changeset 588330449887 - 8245062: HtmlStyle: group and document members for nav, header, summary, details - 8245264: Test runtime/cds/appcds/SignedJar.java fails - ... and 71 more: https://git.openjdk.org/mobile/compare/44bde0d0...c38f0064 The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=mobile&pr=23&range=00.0 - jdk:master: https://webrevs.openjdk.org/?repo=mobile&pr=23&range=00.1 Changes: https://git.openjdk.org/mobile/pull/23/files Stats: 131113 lines in 1288 files changed: 58777 ins; 66629 del; 5707 mod Patch: https://git.openjdk.org/mobile/pull/23.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/23/head:pull/23 PR: https://git.openjdk.org/mobile/pull/23 From duke at openjdk.org Fri Apr 26 13:33:47 2024 From: duke at openjdk.org (J. Duke) Date: Fri, 26 Apr 2024 13:33:47 GMT Subject: Withdrawn: Merge jdk:master In-Reply-To: References: Message-ID: On Thu, 25 Apr 2024 12:43:53 GMT, J. Duke wrote: > Hi all, > > this is an _automatically_ generated pull request to notify you that there are 337 commits from the branch `jdk:master`that can **not** be merged into the branch `master`: > > The following files contains merge conflicts: > > - make/autoconf/flags-cflags.m4 > - make/autoconf/toolchain.m4 > - make/common/JdkNativeCompilation.gmk > > All Committers in this [project](https://openjdk.org/census#mobile) have access to my [personal fork](https://github.com/openjdk-bots/mobile) and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). > The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. > The below commands should be run in a local clone of your [personal fork](https://wiki.openjdk.org/display/skara#Skara-Personalforks) of the [openjdk/mobile](https://github.com/openjdk/mobile) repository. > > > # Ensure target branch is up to date > $ git checkout master > $ git pull https://github.com/openjdk/mobile.git master > > # Fetch and checkout the branch for this pull request > $ git fetch https://github.com/openjdk-bots/mobile.git +3:openjdk-bot-3 > $ git checkout openjdk-bot-3 > > # Merge the target branch > $ git merge master > > > When you have resolved the conflicts resulting from the `git merge` command above, run the following commands to create a merge commit: > > > $ git add paths/to/files/with/conflicts > $ git commit -m 'Merge jdk:master' > > > > When you have created the merge commit, run the following command to push the merge commit to this pull request: > > > $ git push https://github.com/openjdk-bots/mobile.git openjdk-bot-3:3 > > > _Note_: if you are using SSH to push commits to GitHub, then change the URL in the above `git push` command accordingly. > > Thanks, > J. Duke This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/mobile/pull/23 From duke at openjdk.org Fri Apr 26 14:03:45 2024 From: duke at openjdk.org (J. Duke) Date: Fri, 26 Apr 2024 14:03:45 GMT Subject: RFR: Merge jdk:master Message-ID: Hi all, this is an _automatically_ generated pull request to notify you that there are 352 commits from the branch `jdk:master`that can **not** be merged into the branch `master`: The following files contains merge conflicts: - make/autoconf/flags-cflags.m4 - make/autoconf/toolchain.m4 - make/common/JdkNativeCompilation.gmk All Committers in this [project](https://openjdk.org/census#mobile) have access to my [personal fork](https://github.com/openjdk-bots/mobile) and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. The below commands should be run in a local clone of your [personal fork](https://wiki.openjdk.org/display/skara#Skara-Personalforks) of the [openjdk/mobile](https://github.com/openjdk/mobile) repository. # Ensure target branch is up to date $ git checkout master $ git pull https://github.com/openjdk/mobile.git master # Fetch and checkout the branch for this pull request $ git fetch https://github.com/openjdk-bots/mobile.git +4:openjdk-bot-4 $ git checkout openjdk-bot-4 # Merge the target branch $ git merge master When you have resolved the conflicts resulting from the `git merge` command above, run the following commands to create a merge commit: $ git add paths/to/files/with/conflicts $ git commit -m 'Merge jdk:master' When you have created the merge commit, run the following command to push the merge commit to this pull request: $ git push https://github.com/openjdk-bots/mobile.git openjdk-bot-4:4 _Note_: if you are using SSH to push commits to GitHub, then change the URL in the above `git push` command accordingly. Thanks, J. Duke ------------- Commit messages: - 8327247: C2 uses up to 2GB of RAM to compile complex string concat in extreme cases - 8330625: Compilation memory statistic: prevent tearing of the final report - 8331063: Some HttpClient tests don't report leaks - 8329850: [AIX] Allow loading of different members of same shared library archive - 8309881: Qualified name of a type element depends on its origin (source vs class) - 8329862: libjli GetApplicationHome cleanups and enhance jli tracing - 8331150: RISC-V: Fix "bad AD file" bug - 8327512: JShell does not work correctly when a class named Object or Throwable is defined - 8322847: java.lang.classfile.BufWriter should specify @throws for its writeXXX methods - 8330181: Move PcDesc cache from nmethod header - ... and 342 more: https://git.openjdk.org/mobile/compare/5ae849d6...5e2ced4b The webrev contains the conflicts with master: - merge conflicts: https://webrevs.openjdk.org/?repo=mobile&pr=24&range=00.conflicts Changes: https://git.openjdk.org/mobile/pull/24/files Stats: 97198 lines in 2569 files changed: 44478 ins; 40864 del; 11856 mod Patch: https://git.openjdk.org/mobile/pull/24.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/24/head:pull/24 PR: https://git.openjdk.org/mobile/pull/24 From duke at openjdk.org Sat Apr 27 19:30:22 2024 From: duke at openjdk.org (J. Duke) Date: Sat, 27 Apr 2024 19:30:22 GMT Subject: RFR: Merge jdk:master [v2] In-Reply-To: References: Message-ID: > Hi all, > > this is an _automatically_ generated pull request to notify you that there are 352 commits from the branch `jdk:master`that can **not** be merged into the branch `master`: > > The following files contains merge conflicts: > > - make/autoconf/flags-cflags.m4 > - make/autoconf/toolchain.m4 > - make/common/JdkNativeCompilation.gmk > > All Committers in this [project](https://openjdk.org/census#mobile) have access to my [personal fork](https://github.com/openjdk-bots/mobile) and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). > The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. > The below commands should be run in a local clone of your [personal fork](https://wiki.openjdk.org/display/skara#Skara-Personalforks) of the [openjdk/mobile](https://github.com/openjdk/mobile) repository. > > > # Ensure target branch is up to date > $ git checkout master > $ git pull https://github.com/openjdk/mobile.git master > > # Fetch and checkout the branch for this pull request > $ git fetch https://github.com/openjdk-bots/mobile.git +4:openjdk-bot-4 > $ git checkout openjdk-bot-4 > > # Merge the target branch > $ git merge master > > > When you have resolved the conflicts resulting from the `git merge` command above, run the following commands to create a merge commit: > > > $ git add paths/to/files/with/conflicts > $ git commit -m 'Merge jdk:master' > > > > When you have created the merge commit, run the following command to push the merge commit to this pull request: > > > $ git push https://github.com/openjdk-bots/mobile.git openjdk-bot-4:4 > > > _Note_: if you are using SSH to push commits to GitHub, then change the URL in the above `git push` command accordingly. > > Thanks, > J. Duke J. Duke has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 353 commits: - Merge jdk:master - 8327247: C2 uses up to 2GB of RAM to compile complex string concat in extreme cases Reviewed-by: mchung, shade - 8330625: Compilation memory statistic: prevent tearing of the final report Reviewed-by: kvn, thartmann - 8331063: Some HttpClient tests don't report leaks Reviewed-by: dfuchs, vtewari, michaelm - 8329850: [AIX] Allow loading of different members of same shared library archive Reviewed-by: mdoerr, mbaesken, stuefe - 8309881: Qualified name of a type element depends on its origin (source vs class) Reviewed-by: darcy, jlahoda - 8329862: libjli GetApplicationHome cleanups and enhance jli tracing Reviewed-by: clanger, stuefe - 8331150: RISC-V: Fix "bad AD file" bug Reviewed-by: fyang - 8327512: JShell does not work correctly when a class named Object or Throwable is defined Reviewed-by: asotona - 8322847: java.lang.classfile.BufWriter should specify @throws for its writeXXX methods Reviewed-by: psandoz - ... and 343 more: https://git.openjdk.org/mobile/compare/a4ce2160...7f86db2f ------------- Changes: https://git.openjdk.org/mobile/pull/24/files Webrev: https://webrevs.openjdk.org/?repo=mobile&pr=24&range=01 Stats: 97201 lines in 2569 files changed: 44478 ins; 40867 del; 11856 mod Patch: https://git.openjdk.org/mobile/pull/24.diff Fetch: git fetch https://git.openjdk.org/mobile.git pull/24/head:pull/24 PR: https://git.openjdk.org/mobile/pull/24 From duke at openjdk.org Sat Apr 27 19:38:28 2024 From: duke at openjdk.org (J. Duke) Date: Sat, 27 Apr 2024 19:38:28 GMT Subject: Integrated: Merge jdk:master In-Reply-To: References: Message-ID: On Fri, 26 Apr 2024 13:27:14 GMT, J. Duke wrote: > Hi all, > > this is an _automatically_ generated pull request to notify you that there are 352 commits from the branch `jdk:master`that can **not** be merged into the branch `master`: > > The following files contains merge conflicts: > > - make/autoconf/flags-cflags.m4 > - make/autoconf/toolchain.m4 > - make/common/JdkNativeCompilation.gmk > > All Committers in this [project](https://openjdk.org/census#mobile) have access to my [personal fork](https://github.com/openjdk-bots/mobile) and can therefore help resolve these merge conflicts (you may want to coordinate who should do this). > The following paragraphs will give an example on how to solve these merge conflicts and push the resulting merge commit to this pull request. > The below commands should be run in a local clone of your [personal fork](https://wiki.openjdk.org/display/skara#Skara-Personalforks) of the [openjdk/mobile](https://github.com/openjdk/mobile) repository. > > > # Ensure target branch is up to date > $ git checkout master > $ git pull https://github.com/openjdk/mobile.git master > > # Fetch and checkout the branch for this pull request > $ git fetch https://github.com/openjdk-bots/mobile.git +4:openjdk-bot-4 > $ git checkout openjdk-bot-4 > > # Merge the target branch > $ git merge master > > > When you have resolved the conflicts resulting from the `git merge` command above, run the following commands to create a merge commit: > > > $ git add paths/to/files/with/conflicts > $ git commit -m 'Merge jdk:master' > > > > When you have created the merge commit, run the following command to push the merge commit to this pull request: > > > $ git push https://github.com/openjdk-bots/mobile.git openjdk-bot-4:4 > > > _Note_: if you are using SSH to push commits to GitHub, then change the URL in the above `git push` command accordingly. > > Thanks, > J. Duke This pull request has now been integrated. Changeset: ec4a3591 Author: J. Duke Committer: Johan Vos URL: https://git.openjdk.org/mobile/commit/ec4a3591c3d6e814813c45651dc03d64ea27aae2 Stats: 97201 lines in 2569 files changed: 44478 ins; 40867 del; 11856 mod Merge ------------- PR: https://git.openjdk.org/mobile/pull/24